Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing refl1d-webview-client to npmjs? #198

Open
bmaranville opened this issue Oct 1, 2024 · 1 comment
Open

Stop publishing refl1d-webview-client to npmjs? #198

bmaranville opened this issue Oct 1, 2024 · 1 comment

Comments

@bmaranville
Copy link
Member

Currently we publishing the webview client code (compiled) to npmjs.com so that it can be served through free CDNs. The use case for this is for developers that want to work with the python library and use the webview interface, but without compiling the client code. The webview python server follows this logic when to serve the client:

  • reads the current client code version from refl1d/webview/client/package.json (which is in the git source tree)
  • checks to see if a client is compiled to refl1d/webview/client/dist/<version>/, and

Now we have workflows that compile the client code and include it in the wheel files that will be automatically published to pypi.org, so most end users will get everything they need with pip install refl1d or pip install refl1d --upgrade --no-dependencies if they are just wanting to upgrade it.

Can we live with the requirement that developers that install from source must compile the client themselves?

@pkienzle
Copy link
Member

Setting up the client using the conda nodejs package is easy enough that we don't need the CDN.

The circumstances where you wouldn't need nodejs are very limited: You are either working on the documentation or you maintaining code that only touches the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants