You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The +incompatible version annotation bypasses the requirement of semantic import versioning for repositories that predate the introduction of modules. The go command now verifies that such a version does not include an explicit go.mod file.
Benthos up until now has been using modules for it's own dependencies (and therefore has a go.mod file) but also has a major version beyond 1 without adding it to the import path. The reason for this was originally because it allowed users importing Benthos through non-module methods to continue, and modules users could continue with a pseudo-version import. More info about this questionable choice of mine can be found here: #232 (comment)
However, Go 1.13 has forced me to choose one (I'm not a fan of copy/pasting the entire codebase into a /v3 subdirectory, sue me.) My plan was always to upgrade Benthos to V3 at the same time and enforce modules from that point onwards, so that's what I'm working on right now.
Hey all, with Go 1.13 out there was a change to add more version validation when pulling dependencies with modules: https://tip.golang.org/doc/go1.13#version-validation, the important part specifically is:
Benthos up until now has been using modules for it's own dependencies (and therefore has a
go.mod
file) but also has a major version beyond 1 without adding it to the import path. The reason for this was originally because it allowed users importing Benthos through non-module methods to continue, and modules users could continue with a pseudo-version import. More info about this questionable choice of mine can be found here: #232 (comment)However, Go 1.13 has forced me to choose one (I'm not a fan of copy/pasting the entire codebase into a
/v3
subdirectory, sue me.) My plan was always to upgrade Benthos to V3 at the same time and enforce modules from that point onwards, so that's what I'm working on right now.The migration guide outlines all the upcoming changes: https://github.com/Jeffail/benthos/blob/master/docs/migration/v3.md
Working off a branch at: https://github.com/Jeffail/benthos/tree/v3
The text was updated successfully, but these errors were encountered: