Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RESP3 protocol support #2565

Closed
21 of 22 tasks
uglide opened this issue Jan 26, 2023 · 4 comments
Closed
21 of 22 tasks

Add RESP3 protocol support #2565

uglide opened this issue Jan 26, 2023 · 4 comments
Labels
feature New feature tracking-issue An issue container, effectively an epic

Comments

@uglide
Copy link
Contributor

uglide commented Jan 26, 2023

Version: 4.4.2
Platform: Any
Description: redis-py doesn't support RESP3 protocol.

@uglide uglide moved this to Todo in RESP 3 Backlog Jan 26, 2023
@dvora-h dvora-h added the feature New feature label Jan 29, 2023
@chayim
Copy link
Contributor

chayim commented Feb 9, 2023

@dvora-h
Copy link
Collaborator

dvora-h commented Feb 9, 2023

  • Add protocol option to the connection

    • Async Connection (M)
    • Async Cluster Connection (S)
    • Async Unix Connection (XS)
    • Async SSL Connection (XS)
    • Connection
    • Cluster Connection
    • Unix Connection
    • SSL Connection
    • Pubsub (L)
    • Async Pubsub (L)
  • Refactor parsers to make it easier to add support to more protocols

  • Add the RESP3 parsers

    • RESP3 parse_response
    • Response callbacks to RESP3
    • Explore improvement sync and async parsers
    • Clean up parser helpers functions (S)
    • Add support for modules changes (unknown, waiting for modules changes)
  • Add test env for RESP3 specifically (XS)

  • Add examples (XS)

  • Update README (XS)

  • Change protocol with HELLO command (S)

@chayim
Copy link
Contributor

chayim commented Feb 19, 2023

Nice to have:

  • Migrate tests to classes

@chayim chayim added the tracking-issue An issue container, effectively an epic label Jul 18, 2023
@chayim
Copy link
Contributor

chayim commented Nov 2, 2023

Closing as cleanup, released.

@chayim chayim closed this as completed Nov 2, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in RESP 3 Backlog Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature tracking-issue An issue container, effectively an epic
Projects
Status: Done
Development

No branches or pull requests

3 participants