Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARGV eval parameters should be same type as the script (String or byte[]) #1015

Closed
danielsomekh opened this issue Apr 11, 2019 · 1 comment
Closed
Labels
status: declined A suggestion or change that we dont feel we should currently apply

Comments

@danielsomekh
Copy link

Bug Report

In RedisScriptingCommands, the generic V (corresponding to the values stored in the cache), is used as the argument type for the values that are passed into the ARGV Lua variable. But, these arguments have no direct relation to the data stored in the cache. Because the only use of these arguments is in the script, they should have the same type as the script (as discussed in #1010, the script type will be changed to String or byte[]).

https://github.com/lettuce-io/lettuce-core/blob/master/src/main/java/io/lettuce/core/api/sync/RedisScriptingCommands.java#L77

@mp911de mp911de added the status: declined A suggestion or change that we dont feel we should currently apply label Apr 11, 2019
@mp911de
Copy link
Collaborator

mp911de commented Apr 11, 2019

These aren't keys either. So basically, every approach is potentially wrong. One might want to use plain strings, other people put in JSON or use any other serialized format. That being said, we're not going to change ARGV from V to something different.

@mp911de mp911de closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we dont feel we should currently apply
Projects
None yet
Development

No branches or pull requests

2 participants