From b5716ee82926316f7764b834eec636f5652d5600 Mon Sep 17 00:00:00 2001 From: Bjorn Svensson Date: Thu, 25 Nov 2021 08:09:23 +0100 Subject: [PATCH] Valgrind returns error exit code when errors found (#1011) By default Valgrind will return the exit code from the tested process. Since our test can return 0 (ALL TESTS PASS) even when a leak was found we need to tell Valgrind to return an error code. This will fail the CI job when issues are found. --- .github/workflows/build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c43beb606..e4dde05eb 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -36,7 +36,7 @@ jobs: # - name: Run tests under valgrind # env: # SKIPS_AS_FAILS: 1 - # TEST_PREFIX: valgrind --track-origins=yes --leak-check=full + # TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full # run: $GITHUB_WORKSPACE/test.sh centos7: @@ -75,7 +75,7 @@ jobs: env: SKIPS_AS_FAILS: 1 TEST_SSL: 1 - TEST_PREFIX: valgrind --track-origins=yes --leak-check=full + TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full run: $GITHUB_WORKSPACE/test.sh centos8: @@ -115,7 +115,7 @@ jobs: env: SKIPS_AS_FAILS: 1 TEST_SSL: 1 - TEST_PREFIX: valgrind --track-origins=yes --leak-check=full + TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full run: $GITHUB_WORKSPACE/test.sh macos: