Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra ansible scripts #6813

Closed
feloy opened this issue May 15, 2023 · 3 comments
Closed

Infra ansible scripts #6813

feloy opened this issue May 15, 2023 · 3 comments
Labels
area/infra Issues or PRs related to setting up or fixing things in infrastructure. Mostly CI infrastructure. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@feloy
Copy link
Contributor

feloy commented May 15, 2023

/kind bug

Issues I have noticed after ansible scripts to deploy test Infra have been merged:

  • the infra-test.yaml workflow runs for every PR. It should run only if files into scripts/ansible are modified
  • the infra-apply.yaml workflow is not running when a PR is merged into main.
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 15, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label May 15, 2023
@rm3l rm3l mentioned this issue May 16, 2023
Merged
3 tasks
@rm3l
Copy link
Member

rm3l commented May 16, 2023

the infra-test.yaml workflow runs for every PR. It should run only if files into scripts/ansible are modified

There is also one thing I noticed while quickly creating #6823 : the workflow in infra-test.yaml makes use of GitHub Repository Secrets. For security reasons, GitHub will not inject secrets to PRs created from forks. So this workflow will actually never pass if a PR is created from a fork with changes in scripts/ansible.

@rm3l rm3l added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering area/infra Issues or PRs related to setting up or fixing things in infrastructure. Mostly CI infrastructure. labels May 16, 2023
@github-actions
Copy link
Contributor

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 14, 2023
@github-project-automation github-project-automation bot moved this to Done ✅ in odo Project Sep 14, 2023
@rm3l rm3l closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/infra Issues or PRs related to setting up or fixing things in infrastructure. Mostly CI infrastructure. area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
odo Project
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rm3l @feloy