Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ComponentSettings struct and LocalConfigProvider interface #5984

Closed
rm3l opened this issue Jul 28, 2022 · 0 comments · Fixed by #6057
Closed

Cleanup ComponentSettings struct and LocalConfigProvider interface #5984

rm3l opened this issue Jul 28, 2022 · 0 comments · Fixed by #6057
Labels
area/refactoring Issues or PRs related to code refactoring kind/task Issue is actionable task

Comments

@rm3l
Copy link
Member

rm3l commented Jul 28, 2022

/kind task
/area refactoring

This is a follow-up to a discussion in #5852

Would it be possible to clean up the code by removing both Name and AppName fields from the ComponentSettings struct?
I guess this will require cleaning up further things, like removing the GetApplication and GetName methods from the LocalConfigProvider interface as well..

Maybe I've missed something, but I think that this way, we would be sure no one can use that information (I've tested this PR against an existing project that already has component and app names in its env.yaml files, but then from the code perspective, there is currently nothing in this PR preventing from loading and using such information).

Originally posted by @rm3l in #5852 (review)

@rm3l rm3l added kind/task Issue is actionable task area/refactoring Issues or PRs related to code refactoring labels Jul 28, 2022
@rm3l rm3l linked a pull request Aug 29, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/refactoring Issues or PRs related to code refactoring kind/task Issue is actionable task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant