odo dev prints ✗ Executing the application after cleaning up the resources

[dharmit]

/kind bug
/area dev

What versions of software are you using?

Operating System: all

Output of odo version: main

How did you run odo exactly?

• Built odo from the main branch and ran odo dev
• Hit Ctrl+C to stop the odo dev session

Actual behavior

odo prints ✗ Executing the application (command: run) [1m] after cleaning up the resources. But it doesn't error out - echo $? output is 0.

...
Cancelling deployment.
This is non-preemptive operation, it will wait for other tasks to finish first

Cleaning resources, please wait
 ✗  Executing the application (command: run) [1m]

Expected behavior

odo shouldn't print such a message

[valaparthvi]

Do not print the error message, since the cleaning up is already done, and the message doesn't make sense.

[feloy]

Please take #5933 into account, as it works around this

[dharmit]

Please take #5933 into account, as it works around this

Do you mean that PR addresses this issue? 🤔
Not sure if I understand what you are suggesting here.

[dharmit]

Do you mean that PR addresses this issue? thinking Not sure if I understand what you are suggesting here.

I just checked this out myself and it seems like your PR doesn't address this issue:

$ odo dev                     
  __
 /  \__     Developing using the devfile-nodejs-deploy Devfile
 \__/  \    Namespace: myproject
 /  \__/    odo version: v3.0.0-beta1
 \__/

↪ Deploying to the cluster in developer mode
 •  Waiting for Kubernetes resources  ...
 ✓  Creating kind Pod 
 ⚠  Pod is Pending
 ⚠  0/1 nodes are available: 1 pod has unbound immediate PersistentVolumeClaims. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.
 ✓  Pod is Running
 ✓  Syncing files into the container [232ms]
 ✓  Building your application in container on cluster (command: install) [2s]
 •  Executing the application (command: run)  ...
 - Forwarding from 127.0.0.1:40001 -> 3000

Watching for changes in the current directory /home/dshah/src/devfile-nodejs-deploy
Press Ctrl+c to exit `odo dev` and delete resources from the cluster

Pushing files...


File /home/dshah/src/devfile-nodejs-deploy/sedunRjCg changed

File /home/dshah/src/devfile-nodejs-deploy/server.js changed
 •  Waiting for Kubernetes resources  ...
 ✓  Syncing files into the container [96ms]
 ✓  Building your application in container on cluster (command: install) [1s]
 ✗  Executing the application (command: run) [21s]
 •  Executing the application (command: run)  ...

Watching for changes in the current directory /home/dshah/src/devfile-nodejs-deploy
Press Ctrl+c to exit `odo dev` and delete resources from the cluster

^C

Cancelling deployment.
This is non-preemptive operation, it will wait for other tasks to finish first

Cleaning resources, please wait
 ✗  Executing the application (command: run) [2m]

It prints the message in question just like the code from main branch does.