Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context feature does many requests to the kafka that aren't needed #1623

Closed
wtrocki opened this issue Jul 1, 2022 · 1 comment
Closed

Context feature does many requests to the kafka that aren't needed #1623

wtrocki opened this issue Jul 1, 2022 · 1 comment
Labels
bug Something isn't working needs-triage

Comments

@wtrocki
Copy link
Collaborator

wtrocki commented Jul 1, 2022

Description

Example like here. We are fetching entire kafka object only to get id that we have in context anyway:

kafkaInstance, err := contextutil.GetCurrentKafkaInstance(f)
if err != nil {
	return err
}

opts.kafkaID = kafkaInstance.GetId()
@wtrocki wtrocki added the bug Something isn't working label Jul 1, 2022
@rkpattnaik780
Copy link
Contributor

Duplicate of #1522

@rkpattnaik780 rkpattnaik780 marked this as a duplicate of #1522 Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wtrocki @rkpattnaik780 @app-services-ci