-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering: Add a "Reset all filters" button to the Events page #340
Comments
I will pick this up today :) |
If the header is growing, does that mean the list area will be super tiny on an iPhone 4? |
If so we might be able to mitigate that in the future by hiding the header like in #66 |
yep @robbiemccorkell I reckon that's a good shout - only the date remains sticky. Let's add the reset button and I'll talk to @stevecottle about whether we should do the rest |
I appreciate I'm a bit too late to the party, but would this look better as a thin sticky banner saying something like "Filters applied" at the top of the list with a ✖️icon on the right? Like one of the date headers, but a different colour, maybe the green we use for the number badge. This look like a bit of an afterthought and will make a lot of the UI move in an odd way when tapped. |
Description of issue
Currently if you have filter(s) applied it requires a minimum of 2 taps to reset to the default state. If you have multiple filters enabled then it's even more, requiring you to open each filter individually to reset them to the default state.
Expected behaviour
When filter(s) are set a "Reset all filters" button appears on the Events page.
The text was updated successfully, but these errors were encountered: