Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParamTypeFromStrictTypedPropertyRector and AddParamTypeFromPropertyTypeRector seems similar, one should be removed #8328

Closed
samsonasik opened this issue Nov 28, 2023 · 2 comments · Fixed by rectorphp/rector-src#5293
Closed

ParamTypeFromStrictTypedPropertyRector and AddParamTypeFromPropertyTypeRector seems similar, one should be removed #8328

samsonasik opened this issue Nov 28, 2023 · 2 comments · Fixed by rectorphp/rector-src#5293
Labels
bug

Comments

@samsonasik
Copy link
Member

Bug Report

Subject Details
Rector version e.g. dev-main (invoke vendor/bin/rector --version)

Minimal PHP Code Causing Issue

Both rules seems equal functionality:

ParamTypeFromStrictTypedPropertyRector: https://getrector.com/demo/d316c71d-6f95-4454-a1bc-7171a9244b2e
AddParamTypeFromPropertyTypeRector: https://getrector.com/demo/f2361cb4-1bf8-40ba-81a9-9e813bebe8e0

Expected Behaviour

One of them need to be removed to avoid maintain double similar feature.
@samsonasik samsonasik added the bug label Nov 28, 2023
@samsonasik samsonasik mentioned this issue Nov 28, 2023
Merged
@samsonasik
Copy link
Member Author

I created PR for it

@TomasVotruba
Copy link
Member

TomasVotruba commented Nov 28, 2023 •
edited
Loading

Indeed :) good catch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @TomasVotruba