-
-
Notifications
You must be signed in to change notification settings - Fork 701
/
Copy pathNullToStrictStringFuncCallArgRector.php
278 lines (276 loc) · 9.58 KB
/
NullToStrictStringFuncCallArgRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
<?php
declare (strict_types=1);
namespace Rector\Php81\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Cast\String_ as CastString_;
use PhpParser\Node\Expr\ConstFetch;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Identifier;
use PhpParser\Node\Scalar\InterpolatedString;
use PhpParser\Node\Scalar\String_;
use PHPStan\Analyser\Scope;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\FunctionReflection;
use PHPStan\Reflection\Native\ExtendedNativeParameterReflection;
use PHPStan\Reflection\Native\NativeFunctionReflection;
use PHPStan\Reflection\ParametersAcceptor;
use PHPStan\Type\ErrorType;
use PHPStan\Type\MixedType;
use PHPStan\Type\NullType;
use PHPStan\Type\Type;
use PHPStan\Type\UnionType;
use Rector\NodeAnalyzer\ArgsAnalyzer;
use Rector\NodeAnalyzer\PropertyFetchAnalyzer;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\NodeTypeResolver\PHPStan\ParametersAcceptorSelectorVariantsWrapper;
use Rector\Php81\Enum\NameNullToStrictNullFunctionMap;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Rector\Reflection\ReflectionResolver;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector\NullToStrictStringFuncCallArgRectorTest
*/
final class NullToStrictStringFuncCallArgRector extends AbstractRector implements MinPhpVersionInterface
{
/**
* @readonly
*/
private ReflectionResolver $reflectionResolver;
/**
* @readonly
*/
private ArgsAnalyzer $argsAnalyzer;
/**
* @readonly
*/
private PropertyFetchAnalyzer $propertyFetchAnalyzer;
/**
* @readonly
*/
private ValueResolver $valueResolver;
public function __construct(ReflectionResolver $reflectionResolver, ArgsAnalyzer $argsAnalyzer, PropertyFetchAnalyzer $propertyFetchAnalyzer, ValueResolver $valueResolver)
{
$this->reflectionResolver = $reflectionResolver;
$this->argsAnalyzer = $argsAnalyzer;
$this->propertyFetchAnalyzer = $propertyFetchAnalyzer;
$this->valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Change null to strict string defined function call args', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
preg_split("#a#", null);
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
preg_split("#a#", '');
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node) : ?Node
{
if ($this->shouldSkip($node)) {
return null;
}
$scope = $node->getAttribute(AttributeKey::SCOPE);
if (!$scope instanceof Scope) {
return null;
}
$args = $node->getArgs();
$positions = $this->argsAnalyzer->hasNamedArg($args) ? $this->resolveNamedPositions($node, $args) : $this->resolveOriginalPositions($node, $scope);
if ($positions === []) {
return null;
}
$classReflection = $scope->getClassReflection();
$isTrait = $classReflection instanceof ClassReflection && $classReflection->isTrait();
$functionReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($node);
if (!$functionReflection instanceof FunctionReflection) {
return null;
}
$parametersAcceptor = ParametersAcceptorSelectorVariantsWrapper::select($functionReflection, $node, $scope);
$isChanged = \false;
foreach ($positions as $position) {
$result = $this->processNullToStrictStringOnNodePosition($node, $args, $position, $isTrait, $scope, $parametersAcceptor);
if ($result instanceof Node) {
$node = $result;
$isChanged = \true;
}
}
if ($isChanged) {
return $node;
}
return null;
}
public function provideMinPhpVersion() : int
{
return PhpVersionFeature::DEPRECATE_NULL_ARG_IN_STRING_FUNCTION;
}
/**
* @param Arg[] $args
* @return int[]|string[]
*/
private function resolveNamedPositions(FuncCall $funcCall, array $args) : array
{
$functionName = $this->nodeNameResolver->getName($funcCall);
$argNames = NameNullToStrictNullFunctionMap::FUNCTION_TO_PARAM_NAMES[$functionName];
$positions = [];
foreach ($args as $position => $arg) {
if (!$arg->name instanceof Identifier) {
continue;
}
if (!$this->nodeNameResolver->isNames($arg->name, $argNames)) {
continue;
}
$positions[] = $position;
}
return $positions;
}
/**
* @param Arg[] $args
* @param int|string $position
*/
private function processNullToStrictStringOnNodePosition(FuncCall $funcCall, array $args, $position, bool $isTrait, Scope $scope, ParametersAcceptor $parametersAcceptor) : ?FuncCall
{
if (!isset($args[$position])) {
return null;
}
$argValue = $args[$position]->value;
if ($argValue instanceof ConstFetch && $this->valueResolver->isNull($argValue)) {
$args[$position]->value = new String_('');
$funcCall->args = $args;
return $funcCall;
}
$type = $this->nodeTypeResolver->getType($argValue);
if ($type->isString()->yes()) {
return null;
}
$nativeType = $this->nodeTypeResolver->getNativeType($argValue);
if ($nativeType->isString()->yes()) {
return null;
}
if ($this->shouldSkipType($type)) {
return null;
}
if ($argValue instanceof InterpolatedString) {
return null;
}
if ($this->isAnErrorType($argValue, $nativeType, $scope)) {
return null;
}
if ($this->shouldSkipTrait($argValue, $type, $isTrait)) {
return null;
}
$parameter = $parametersAcceptor->getParameters()[$position] ?? null;
if ($parameter instanceof ExtendedNativeParameterReflection && $parameter->getType() instanceof UnionType) {
$parameterType = $parameter->getType();
if (!$this->isValidUnionType($parameterType)) {
return null;
}
}
$args[$position]->value = new CastString_($argValue);
$funcCall->args = $args;
return $funcCall;
}
private function isValidUnionType(Type $type) : bool
{
if (!$type instanceof UnionType) {
return \false;
}
foreach ($type->getTypes() as $childType) {
if ($childType->isString()->yes()) {
continue;
}
if ($childType->isNull()->yes()) {
continue;
}
return \false;
}
return \true;
}
private function shouldSkipType(Type $type) : bool
{
return !$type instanceof MixedType && !$type->isNull()->yes() && !$this->isValidUnionType($type);
}
private function shouldSkipTrait(Expr $expr, Type $type, bool $isTrait) : bool
{
if (!$type instanceof MixedType) {
return \false;
}
if (!$isTrait) {
return \false;
}
if ($type->isExplicitMixed()) {
return \false;
}
if (!$expr instanceof MethodCall) {
return $this->propertyFetchAnalyzer->isLocalPropertyFetch($expr);
}
return \true;
}
private function isAnErrorType(Expr $expr, Type $type, Scope $scope) : bool
{
if ($type instanceof ErrorType) {
return \true;
}
$parentScope = $scope->getParentScope();
if ($parentScope instanceof Scope) {
return $parentScope->getType($expr) instanceof ErrorType;
}
return $type instanceof MixedType && !$type->isExplicitMixed() && $type->getSubtractedType() instanceof NullType;
}
/**
* @return int[]|string[]
*/
private function resolveOriginalPositions(FuncCall $funcCall, Scope $scope) : array
{
$functionReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($funcCall);
if (!$functionReflection instanceof NativeFunctionReflection) {
return [];
}
$parametersAcceptor = ParametersAcceptorSelectorVariantsWrapper::select($functionReflection, $funcCall, $scope);
$functionName = $functionReflection->getName();
$argNames = NameNullToStrictNullFunctionMap::FUNCTION_TO_PARAM_NAMES[$functionName];
$positions = [];
foreach ($parametersAcceptor->getParameters() as $position => $parameterReflection) {
if (\in_array($parameterReflection->getName(), $argNames, \true)) {
$positions[] = $position;
}
}
return $positions;
}
private function shouldSkip(FuncCall $funcCall) : bool
{
$functionNames = \array_keys(NameNullToStrictNullFunctionMap::FUNCTION_TO_PARAM_NAMES);
if (!$this->nodeNameResolver->isNames($funcCall, $functionNames)) {
return \true;
}
return $funcCall->isFirstClassCallable();
}
}