Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where PEP 561 .pyi stub files are ignored #84

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Fix an issue where PEP 561 .pyi stub files are ignored #84

merged 5 commits into from
Apr 20, 2020

Conversation

BvB93
Copy link
Contributor

@BvB93 BvB93 commented Apr 10, 2020

Previously the in PEP 561 introduced .pyi stub files were ignored by pytest-mypy, in contrast with mypy itself which handles them just fine.
This pull requests addresses aforementioned issue.

See also: https://mypy.readthedocs.io/en/stable/stubs.html

@BvB93 BvB93 marked this pull request as draft April 10, 2020 15:52
BvB93 and others added 3 commits April 10, 2020 18:14
Skip a .py file if an identically named .pyi file already exists as pytest will complain about duplicate modules otherwise.
@BvB93 BvB93 marked this pull request as ready for review April 10, 2020 20:22
@dmtucker dmtucker added this to the 0.6.2 milestone Apr 12, 2020
Copy link
Collaborator

@dmtucker dmtucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 👍

@BvB93
Copy link
Contributor Author

BvB93 commented Apr 18, 2020

Annoying, it seems two tests ran into travis walltime issues.

@dmtucker dmtucker changed the title Fixed an issue where PEP 561 .pyi stub files were ignored Fix an issue where PEP 561 .pyi stub files are ignored Apr 20, 2020
@dmtucker dmtucker merged commit aa6d4cf into realpython:master Apr 20, 2020
francomattar added a commit to francomattar/Nmypy-pytest that referenced this pull request Dec 13, 2024
* Fixed an issue where .pyi files were ignored

* Skip a .py file if an identically named .pyi file already exists

Skip a .py file if an identically named .pyi file already exists as pytest will complain about duplicate modules otherwise.

* Removed a redundant if/else statement

* Added a test for .pyi files

* Implemented realpython/pytest-mypy#84 (comment)
nayanzin33sergey added a commit to nayanzin33sergey/Python-pytest-mypy that referenced this pull request Dec 18, 2024
* Fixed an issue where .pyi files were ignored

* Skip a .py file if an identically named .pyi file already exists

Skip a .py file if an identically named .pyi file already exists as pytest will complain about duplicate modules otherwise.

* Removed a redundant if/else statement

* Added a test for .pyi files

* Implemented realpython/pytest-mypy#84 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants