Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic release deployment #129

Merged
merged 3 commits into from
Oct 15, 2022
Merged

Fix automatic release deployment #129

merged 3 commits into from
Oct 15, 2022

Conversation

dmtucker
Copy link
Collaborator

Resolve #104

This will not work until the project has repository secrets for PYPI_USERNAME and PYPI_PASSWORD:
https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository

I don't have permission to do that, so @dbader will have to do it.

@dbader
Copy link
Member

dbader commented Jan 24, 2022

@dmtucker Since you're a maintainer on the PyPI project (https://pypi.org/project/pytest-mypy/) as far as I know you should be able to set up CI deploys through that. (Personally, I'm not a fan of putting PyPI credentials on CI for security reasons.)

@dmtucker
Copy link
Collaborator Author

@dbader It's a lack of permissions on the GitHub side (I don't have access to the Settings tab for the repo).

Personally, I'm not a fan of putting PyPI credentials on CI for security reasons.

We can leave it manual if you'd prefer... FWIW, PyPI now offers per-project tokens that can be revoked on-demand. That's what Travis has been using so far (encrypted there, of course).

@dmtucker
Copy link
Collaborator Author

@dbader Would you mind making me an admin on this GitHub repo? Auto-deploy through Travis no longer works, and I can't set it up via GitHub Actions without admin.

@dbader
Copy link
Member

dbader commented Sep 28, 2022

@dmtucker Happy to make you an admin -- I don't think that's possible on a personal GitHub account (which this repo is on). What I could do is move this repo over to the github.com/realpython org account and then add you as a repo admin. Or do you know if there's a way to accomplish this with an individual account? (All I see is the option to add collaborators)

@dmtucker
Copy link
Collaborator Author

@dbader Interesting, I didn't realize that, but the docs seems to confirm it:

Collaborators on a personal repository can pull (read) the contents of the repository and push (write) changes to the repository.

Moving to realpython works for me 👍

@dbader
Copy link
Member

dbader commented Oct 14, 2022

@dmtucker Done, I've migrated the repo to the @realpython org and gave you admin access 👍

@dmtucker
Copy link
Collaborator Author

Right on, thank you!

@dmtucker dmtucker added this to the 0.10.1 milestone Oct 15, 2022
@dmtucker dmtucker merged commit 5cc71fd into realpython:main Oct 15, 2022
@dmtucker dmtucker deleted the travis branch October 15, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis-ci.org has moved to travis-ci.com
2 participants