Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop injecting MypyStatusItem in pytest_collection_modifyitems to fix --looponfail #109

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

dmtucker
Copy link
Collaborator

@dmtucker dmtucker commented Oct 15, 2020

Resolve #85

This behaves much better.

  • Using --looponfail should no longer crash or run duplicates.
  • The status check can now be run by node ID on any file (though, it may not be a really useful thing to do).
  • Injecting just MypyFileItems in a pytest_collection_modifyitems hook no longer implies a status check.
    If you want that, you need to inject a MypyStatusItem too.
  • Likewise, the MypyStatusItem is now present in items in pytest_collection_modifyitems.
    Remove it to ignore mypy errors in uncollected modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positives using when using pytest-xdist -f (--looponfail)
1 participant