-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working hot-reload converted over to webpack with all dependencies managed by yarn #757
Comments
I'd be happy to make a pull request into this repo if there was interest. |
This looks promising, is there anything in the gulp/browserify workflow that you have left out? |
I don't think so. I did have to bump a few of the versions of certain dependencies, I visually tested the impact on chrome and Firefox on Linux and windows and saw no issues. But it is something to be aware of. I can make a pull request and we can begin iterating on it if you like until you're happy with it? |
The current theme toolchain is becoming outdated and shows deprecation warnings when run. I'm in favor of moving to the next hot thing (tm), but would like feedback if this is in line with plans by RTD as a whole. Any opinions @ericholscher @agjohnson @humitos ? |
I definitely agree we should try and standardize this with however we end up doing things in RTD. I don't really know this stuff too well, but @davidfischer or @agjohnson probably know best. We're doing a design project over there, which might also impact this, but I think we're moving to webpack. |
We are moving to webpack over the next few months for https://github.com/readthedocs/readthedocs.org (long overdue) so this seems in line with what we are thinking. |
I'd be happy to get the ball rolling with a pull request with how I achieved it. Shall I do that? |
Yes please! |
Closing this, the webpack conversion seems to be humming along quite nicely! 🎉 |
Glad to hear it :) |
No need to take any action on this, but I thought it might be of interest.
I forked this library and I wanted to be able to use webpack and yarn. I have managed to get everything installing and up and running (including a very fast (a second or two) hot-reload).
If you want to see the changes I made see the following:
https://github.com/pymedphys/pymedphys/tree/5168a77b3068ea4b247e11c62b60d92229271cb7/packages/pymedphys_sphinxtheme
The text was updated successfully, but these errors were encountered: