Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images within admonition boxes don't have 'margin-bottom' property #475

Open
umbe1987 opened this issue Oct 6, 2017 · 3 comments
Open
Labels
Bug A bug Needed: patch A pull request is required

Comments

@umbe1987
Copy link

umbe1987 commented Oct 6, 2017

I had to create a customized css with
(theme_overrides.css)

img {
 margin-bottom: 12px !important;
}

to make it work. Actually, this seems to overrides many cases where <img> margin was defined in specific text sections, but in my case it works pretty well.
Just an image to make it clear (in this case, the image is within an admonition box, and following the image there's a nested admonition box):

BEFORE
immagine

AFTER
immagine

@umbe1987 umbe1987 changed the title images within admition boxes don't have 'margin-bottom' property images within admonition boxes don't have 'margin-bottom' property Oct 6, 2017
@Blendify
Copy link
Member

Blendify commented Oct 6, 2017

Hi can you give some example rst markup that causes this issue?

@umbe1987
Copy link
Author

umbe1987 commented Oct 6, 2017

@Blendify Of course! This is an example.

.. tip::
	parent admonition content

	.. image:: /my_image.jpg
 
	.. warning::
		nested admonition

@Blendify Blendify added Bug A bug Needed: patch A pull request is required labels Nov 25, 2017
@jessetan
Copy link
Contributor

@umbe1987 this will also increase the space between images and their captions (produced by figure), perhaps a better CSS selector would be:

:not(.figure) img

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Needed: patch A pull request is required
Projects
None yet
Development

No branches or pull requests

3 participants