Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help porting a Stylish theme to the official repo #435

Closed
CrazyPython opened this issue Jun 19, 2017 · 11 comments
Closed

Help porting a Stylish theme to the official repo #435

CrazyPython opened this issue Jun 19, 2017 · 11 comments

Comments

@CrazyPython
Copy link

CrazyPython commented Jun 19, 2017

I created a (work in progress) Sylish theme that overhauls the CSS:

Without the theme:

without the theme

Assuming you're willing to accept these changes (I certainly hope so 😄 ), could I receive some help porting it to the official theme? (since I'm not familiar with the codebase)

(you can find the theme here)

@Blendify
Copy link
Member

I would be against adding this in a way such as a toggle. One thing we are wanting to do is be able to modify some basic CSS properties in the configuration file. In order for us to start this, we need to merge #404

@CrazyPython
Copy link
Author

@Blendify

I would be against adding this in a way such as a toggle.

Could you clarify?

@Blendify
Copy link
Member

I would rather allow users to easily change major theme colors rather than distributing other sub-themes. Or if we do we can simply distribute different theme.conf files.

@CrazyPython
Copy link
Author

@Blendify Good idea- perhaps the default theme should look better, though?

@Blendify
Copy link
Member

There are a few tweaks that I have been merging in but overall I think it is still the cleanest Sphinx theme.

@CrazyPython
Copy link
Author

@Blendify What about making the text body full-width and making the search box square?

@tuukkamustonen
Copy link

I think a full-width body is bad for readability and rounded vs square search box is irrelevant (=you'll find as many opinions as people...)

@Blendify
Copy link
Member

Being able to optionally change it is something I would like to see us support.

@polyzen
Copy link

polyzen commented Jun 22, 2017

@Blendify, that could be nice, for pages with long lines of code or better handling of zoomed-in contents.

I don't see how this theme looks better, otherwise. Almost everything has been changed, and the contrast is jarring.

@stonecharioteer
Copy link

@Blendify is that option available now? I'd like to be able to change the color to match my company's standard color options without hacking my way around the code too much.

@Blendify
Copy link
Member

No once #404 gets merged we can add more customization options. In the meantime, this is a general todo (see the readme) so there is no need to keep this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants