Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider logging level for TcpResources #510

Closed
bclozel opened this issue Nov 19, 2018 · 2 comments
Closed

Reconsider logging level for TcpResources #510

bclozel opened this issue Nov 19, 2018 · 2 comments
Labels
status/duplicate This is a duplicate of another issue

Comments

@bclozel
Copy link
Member

bclozel commented Nov 19, 2018

Currently, when a new Spring Boot application is started, we're seeing the following:

2018-11-19 14:00:34.340  WARN 23304 --- [           main] reactor.netty.tcp.TcpResources           : [http] resources will use the default LoopResources: DefaultLoopResources {prefix=reactor-http, daemon=true, selectCount=8, workerCount=8}
2018-11-19 14:00:34.341  WARN 23304 --- [           main] reactor.netty.tcp.TcpResources           : [http] resources will use the default ConnectionProvider: PooledConnectionProvider {name=http, poolFactory=reactor.netty.resources.ConnectionProvider$$Lambda$675/0x0000000800595840@38732364}

The Spring Framework and Spring Boot team made significant changes to improve the logging experience.

Could we reconsider the logging level for this? DEBUG sounds reasonable to me. Spring Boot might change the default logging level for TcpResources by default otherwise (we're doing similar things for other servers).

Cc @rstoyanchev

@bclozel bclozel added the type/enhancement A general enhancement label Nov 19, 2018
@violetagg
Copy link
Member

already fixed #487 and will be available in the next release

@violetagg violetagg added status/duplicate This is a duplicate of another issue and removed type/enhancement A general enhancement labels Nov 19, 2018
@violetagg violetagg added this to the 0.7.12.RELEASE milestone Nov 19, 2018
@bclozel
Copy link
Member Author

bclozel commented Nov 19, 2018

Sorry I totally missed that one - thanks @violetagg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/duplicate This is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

2 participants