Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with import packages #209

Closed
janvdbergh opened this issue Nov 2, 2017 · 2 comments
Closed

Problem with import packages #209

janvdbergh opened this issue Nov 2, 2017 · 2 comments
Milestone

Comments

@janvdbergh
Copy link
Contributor

We are using reactor-netty in an OSGi container (Felix). However the Import-Package version of javax.annotation is incorrect. The correct version of the javax.annotation API is 1.0.0.

Expected behavior

The version of javax.annotation in the Import-Package statement in MANIFEST.MF is equal to [1.0,2) or not specified.
Since this dependency is only required at compile time, it can also be removed or made optional.

Actual behavior

The version is automatically set by the version of the com.google.code.findbugs:jsr305 dependency, which is 3.0.2.

Steps to reproduce

Build the code.
Look at the produced MANIFEST.MF file.

Reactor Netty version

0.7.1.RELEASE

JVM version (e.g. java -version)

java version "1.8.0_151"
Java(TM) SE Runtime Environment (build 1.8.0_151-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.151-b12, mixed mode)

OS version (e.g. uname -a)

Darwin Jans-MacBook-Pro.local 17.2.0 Darwin Kernel Version 17.2.0: Fri Sep 29 18:27:05 PDT 2017; root:xnu-4570.20.62~3/RELEASE_X86_64 x86_64

@janvdbergh
Copy link
Contributor Author

Any idea when we could expect a release of version 0.7.2? We are waiting on it for our own releases.

@violetagg
Copy link
Member

0.7.2.RELEASE is out so you should be able to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants