Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong handle is being focused, when crossing #298

Open
byCedric opened this issue Jul 30, 2017 · 3 comments
Open

Wrong handle is being focused, when crossing #298

byCedric opened this issue Jul 30, 2017 · 3 comments

Comments

@byCedric
Copy link
Contributor

I was working on implementing keyboard support for the Range sliders as well. But as previously stated in the issue #131, I encountered some issues when using multiple handles within a Range slider.

Take a look at this:

s38lazuscn

What I'm doing here is moving the handle, with the mouse, across the other handle. The tooltip is being rendered correctly, but unfortunately the "focus" is left on the wrong handle. Or, the wrong handle is being moved. For mouse control this isn't much big of a deal, but for keyboard control its really not that great.

6ofduvfzna

@byCedric byCedric changed the title Wrong handler is being focused when multiple handles cross Wrong handle is being focused when multiple handles cross Jul 30, 2017
@byCedric byCedric changed the title Wrong handle is being focused when multiple handles cross Wrong handle is being focused crossing Jul 30, 2017
@byCedric byCedric changed the title Wrong handle is being focused crossing Wrong handle is being focused, when crossing Jul 30, 2017
@paranoidjk paranoidjk added the bug label Jul 31, 2017
@paranoidjk paranoidjk self-assigned this Jul 31, 2017
@paranoidjk
Copy link
Member

paranoidjk commented Jul 31, 2017

byCedric Thanks for your report.

The logic is correct at here, when you move across handle, actually the first handle is stoped at the second handle start point, then what you are draging is actually the second handle.

That is to say, when you move across handles, there is a active handle exchange happened, but users may not notice that, they looks like the first hanlde is acrosss the second.

But there do have bug as you report, the active handle state did't exchange correctly.

Since this bug is not very crucial,and i am busy right now, i will handle this when i got time.

PS. PR is welcome ~

@Robin-front
Copy link
Contributor

Robin-front commented Aug 4, 2017

and it seems not support keyboardEvent to move handles. should it do ?

@byCedric
Copy link
Contributor Author

byCedric commented Aug 4, 2017

@Robin-front I was the one who implemented it for simple sliders in PR #282. Because of this issue I withheld the implementation for ranges. I will add the PR for keyboard support in ranges tonight (GMT +02:00), because this is now a separate issue.

@paranoidjk If you think its wise to not yet support keyboard for ranges because of this, you can decline the coming PR. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants