Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the HTTP server from the CLI? #873

Closed
amaury1093 opened this issue Feb 15, 2021 · 1 comment · Fixed by #1151
Closed

Remove the HTTP server from the CLI? #873

amaury1093 opened this issue Feb 15, 2021 · 1 comment · Fixed by #1151

Comments

@amaury1093
Copy link
Member

amaury1093 commented Feb 15, 2021

This repo builds a CLI command, which, when passed the --http flag, also serves a HTTP backend.

I'm proposing to remove the --http flag and the HTTP backend.

The reason is that I built a fully-fledged HTTP backend at https://github.com/reacherhq/backend. It's extensible, maintained, documented with an OpenAPI spec, and used in production. The one here is just a sample HTTP backend.

https://github.com/reacherhq/backend also has a Dockerfile and a one-click deploy button to Heroku.

Are there any people strongly disapproving the removal of the HTTP backend from this repo?

@amaury1093
Copy link
Member Author

Please use the warp backend https://github.com/reacherhq/check-if-email-exists/tree/master/backend for a fully-fledged backend.

@amaury1093 amaury1093 unpinned this issue Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant