You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Going by the .npmignore file, it seems that the NPM package once installed shouldn't include typings/test folder as well as Reflect.ts and other files which makes sense, however when installing from NPM it does include these files.
The only reason I bring this up is due to what I believe to be an issue with TypeScript extension for Visual Studio 2015 when performing a clean/rebuild of a project with TypeScript, it deletes the Reflect.js.
I am using JSPM trying to build a simple Angular 2 demo and whenever I build the project, Reflect.js is deleted from the jspm_packages folder even though tsconfig.json is excluding the jspm_packages folder. I think this is because of the matching Reflect.ts/Reflect.js names where the exclude is being ignored/not working for clean but successfully being ignored for build. This leaves my JSPM project unable to resolve the Reflect.js file as it's been deleted. I can confirm this by renaming Reflect.ts to Reflect_.ts and a clean/rebuild leaves the Reflect.js untouched.
Reflect.js is untouched by a clean/rebuild if in the node_modules directory, but not so for the jspm_packages directory.
Provided you do want the files ignored, could the .npmignore be updated to remove these files from the npm package? I think the file contents should be:
node_modules
test
typings
Reflect.ts
tsconfig.json
Thanks for the package either way 👍
The text was updated successfully, but these errors were encountered:
Hi @rbuckton ,
Going by the
.npmignore
file, it seems that the NPM package once installed shouldn't includetypings
/test
folder as well asReflect.ts
and other files which makes sense, however when installing from NPM it does include these files.The only reason I bring this up is due to what I believe to be an issue with TypeScript extension for Visual Studio 2015 when performing a clean/rebuild of a project with TypeScript, it deletes the
Reflect.js
.I am using JSPM trying to build a simple Angular 2 demo and whenever I build the project,
Reflect.js
is deleted from thejspm_packages
folder even thoughtsconfig.json
is excluding thejspm_packages
folder. I think this is because of the matchingReflect.ts
/Reflect.js
names where theexclude
is being ignored/not working for clean but successfully being ignored for build. This leaves my JSPM project unable to resolve theReflect.js
file as it's been deleted. I can confirm this by renamingReflect.ts
toReflect_.ts
and a clean/rebuild leaves theReflect.js
untouched.Below is my
tsconfig.json
for completeness.Reflect.js
is untouched by a clean/rebuild if in thenode_modules
directory, but not so for thejspm_packages
directory.Provided you do want the files ignored, could the
.npmignore
be updated to remove these files from the npm package? I think the file contents should be:Thanks for the package either way 👍
The text was updated successfully, but these errors were encountered: