Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent selfLink to children #43

Closed
alewitt2 opened this issue Sep 27, 2019 · 5 comments
Closed

Add parent selfLink to children #43

alewitt2 opened this issue Sep 27, 2019 · 5 comments
Labels
enhancement New feature or request wishlist

Comments

@alewitt2
Copy link
Member

Parents will add their selflink to all the children they create, every cycle, and remove it on reconciled without delete. It will be an annotation deploy.razee.io.parent: <selflink>. If parent sees another resource's selfLink, will add a warning to child showing its managed by multiple parents

@alewitt2 alewitt2 added the enhancement New feature or request label Sep 27, 2019
@alewitt2
Copy link
Member Author

also need to handle the case where a child might have multiple parents (not a good state to be in, but possible and needs to be handled)

@alewitt2
Copy link
Member Author

should probably not allow the second parent to apply if the child is already managed. should just error out.

@gregswift
Copy link
Contributor

it would need to "try again" after a bit, incase you are shifting ownership, ya?

@alewitt2
Copy link
Member Author

alewitt2 commented Feb 14, 2022

totally agree. it should continue to retry on its normal cycle interval, but not succeed until the other parent has abandoned it.

@kdai7
Copy link
Contributor

kdai7 commented Nov 30, 2022

#360

@kdai7 kdai7 closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wishlist
Projects
None yet
Development

No branches or pull requests

4 participants