Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add request id header if available to application log #868

Merged
merged 3 commits into from
Feb 19, 2025
Merged

feat: add request id header if available to application log #868

merged 3 commits into from
Feb 19, 2025

Conversation

kushsharma
Copy link
Member

Header with name "X-Request-Id" if available in request headers will be added as field in frontier logs.

@vercel Vercel
Copy link

vercel bot commented Feb 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 7:43am

@kushsharma kushsharma marked this pull request as ready for review February 15, 2025 15:40
@coveralls
Copy link

coveralls commented Feb 15, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13407669658

Details

  • 0 of 30 (0.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 32.363%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/server/server.go 0 1 0.0%
pkg/server/interceptors/authorization.go 0 4 0.0%
pkg/server/interceptors/enrich.go 0 6 0.0%
pkg/server/consts/gateway.go 0 7 0.0%
core/webhook/service.go 0 12 0.0%
Totals Coverage Status
Change from base Build 13366631517: -0.03%
Covered Lines: 8251
Relevant Lines: 25495
💛 - Coveralls

@kushsharma kushsharma force-pushed the request-id-header-logger branch from 63ac441 to 4eea7b7 Compare February 16, 2025 05:03
@kushsharma
feat: add request id header if available to application log
dff50a7 
Header with name "X-Request-Id" if available in request
headers will be added as field in frontier logs.

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@kushsharma kushsharma force-pushed the request-id-header-logger branch from 4eea7b7 to dff50a7 Compare February 17, 2025 14:58
@kushsharma
pass request header to downstream webhook post call
a97e5dd 
Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@rsbh rsbh enabled auto-merge (squash) February 19, 2025 07:42
@rsbh rsbh merged commit 5561828 into main Feb 19, 2025
7 checks passed
@rsbh rsbh deleted the request-id-header-logger branch February 19, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsbh rsbh rsbh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushsharma @coveralls @rsbh