Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make org and project name case insensitive #867

Merged
merged 2 commits into from
Feb 8, 2025
Merged

fix: make org and project name case insensitive #867

merged 2 commits into from
Feb 8, 2025

Conversation

kushsharma
Copy link
Member

@kushsharma kushsharma commented Feb 7, 2025 •
edited
Loading

All org and project slugs will be converted to lower case before they are created. Existing org and projects will continue to work as usual.

  • Added additional metrics latency for authenticate GetPrincipal and organization ListByUser methods.

@kushsharma
fix: make org and project name case insensitive
39b21b9 
All org and project slugs will be converted to lower case before
they are created. Existing org and projects will continue to work
as usual.

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 1:28pm

@kushsharma kushsharma marked this pull request as ready for review February 7, 2025 13:17
@coveralls
Copy link

coveralls commented Feb 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13200818094

Details

  • 3 of 18 (16.67%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 32.394%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/metrics/metrics.go 0 1 0.0%
core/authenticate/service.go 1 4 25.0%
core/organization/service.go 0 4 0.0%
internal/metrics/service.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
internal/metrics/metrics.go 1 0.0%
Totals Coverage Status
Change from base Build 13173546956: -0.006%
Covered Lines: 8251
Relevant Lines: 25471
💛 - Coveralls

@kushsharma
add additional latency metrics for few service calls
d6fc71d 
Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@rsbh rsbh merged commit 670bf36 into main Feb 8, 2025
7 checks passed
@rsbh rsbh deleted the org-proj-slug-lower branch February 8, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsbh rsbh rsbh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushsharma @coveralls @rsbh