feat: schema generator #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove slug from actions and namepaces
add namespaceId to roles and actions
krtkvrm
reviewed
Dec 8, 2021
krtkvrm
reviewed
Dec 8, 2021
krtkvrm
reviewed
Dec 9, 2021
internal/authz/spicedb/spicedb.go
Outdated
|
|
||
| func (p *Policy) AddPolicy(schema string) error { | ||
| request := &pb.WriteSchemaRequest{Schema: schema} | ||
| _, err := p.client.WriteSchema(context.Background(), request) |
krtkvrm
reviewed
Dec 9, 2021
| return transformedPolicies, nil | ||
| } | ||
|
|
||
| func (s Store) CreatePolicy(ctx context.Context, policyToCreate model.Policy) ([]model.Policy, error) { |
krtkvrm
reviewed
Dec 9, 2021
| return s.fetchNamespacePolicies(ctx, newPolicy.NamespaceID) | ||
| } | ||
|
|
||
| func (s Store) UpdatePolicy(ctx context.Context, id string, toUpdate model.Policy) ([]model.Policy, error) { |
krtkvrm
reviewed
Dec 9, 2021
store/postgres/policy.go
Outdated
| func (s Store) fetchNamespacePolicies(ctx context.Context, namespaceId string) ([]model.Policy, error) { | ||
| var fetchedPolicies []Policy | ||
|
|
||
| query := fmt.Sprintf("%s %s", listPolicyQuery, fmt.Sprintf("WHERE p.namespace_id='%s'", namespaceId)) |
There was a problem hiding this comment.
WHERE p.namespace_id='%s' -> WHERE p.namespace_id='$1'
krtkvrm
reviewed
Dec 9, 2021
store/postgres/roles.go
Outdated
| getRoleQuery = `SELECT id, name, types, namespace, metadata, created_at, updated_at from roles where id=$1;` | ||
| listRolesQuery = `SELECT id, name, types, namespace, metadata, created_at, updated_at from roles;` | ||
| updateRoleQuery = `UPDATE roles SET name = $2, types = $3, namespace = $4, metadata = $5, updated_at = now() where id = $1;` | ||
| createRoleQuery = `INSERT into roles(id, name, types, namespace_id, namespac, metadata) values($1, $2, $3, $4, $4, $5) RETURNING id, name, types, namespace_id, metadata, created_at, updated_at;` |
krtkvrm
reviewed
Dec 10, 2021
| func (s Store) fetchNamespacePolicies(ctx context.Context, namespaceId string) ([]model.Policy, error) { | ||
| var fetchedPolicies []Policy | ||
|
|
||
| query := fmt.Sprintf("%s %s", listPolicyQuery, "WHERE p.namespace_id='$1'") |
krtkvrm
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.