Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] QMIX: No backprop on the (mixer) hypernetworks? #5003

Closed
rbokade opened this issue Jun 20, 2019 · 1 comment · Fixed by #5014
Closed

[rllib] QMIX: No backprop on the (mixer) hypernetworks? #5003

rbokade opened this issue Jun 20, 2019 · 1 comment · Fixed by #5014
Assignees
Labels
bug Something that is supposed to be working; but isn't

Comments

@rbokade
Copy link

rbokade commented Jun 20, 2019

QMIX: No backprop on the (mixer) hypernetworks?

Source code / logs

    # Setup optimizer
    self.params = list(self.model.parameters())
    self.loss = QMixLoss(self.model, self.target_model, self.mixer,
                         self.target_mixer, self.n_agents, self.n_actions,
                         self.config["double_q"], self.config["gamma"])
@ericl
Copy link
Contributor

ericl commented Jun 20, 2019

It looks like this is missing from the port: self.params += list(self.mixer.parameters())

@ericl ericl added the bug Something that is supposed to be working; but isn't label Jun 20, 2019
@ericl ericl self-assigned this Jun 20, 2019
@richardliaw richardliaw changed the title QMIX: No backprop on the (mixer) hypernetworks? [rllib] QMIX: No backprop on the (mixer) hypernetworks? Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants