Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to pass size=0 in ActorPoolStrategy #40393

Closed
malhotra18 opened this issue Oct 17, 2023 · 2 comments · Fixed by #47072
Closed

Able to pass size=0 in ActorPoolStrategy #40393

malhotra18 opened this issue Oct 17, 2023 · 2 comments · Fixed by #47072
Labels
bug Something that is supposed to be working; but isn't data Ray Data-related issues good-first-issue Great starter issue for someone just starting to contribute to Ray P1 Issue that should be fixed within a few weeks

Comments

@malhotra18
Copy link

Incorrect sequence of conditions identified in compute.py

        if size:
            if size < 1:
                raise ValueError("size must be >= 1", size)
            if max_size is not None or min_size is not None:
                raise ValueError(
                    "min_size and max_size cannot be set at the same time as `size`"
                )
            min_size = size
            max_size = size

when size=0 is passed ValueError won't get raised as uber level condition expression will be false.

@anyscalesam
Copy link
Contributor

@malhotra18 good catch - can you raise a PR for this?

@anyscalesam anyscalesam added @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. core Issues that should be addressed in Ray Core triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 21, 2024
@jjyao jjyao added P1 Issue that should be fixed within a few weeks triage Needs triage (eg: priority, bug/not-bug, and owning component) data Ray Data-related issues and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) P1 Issue that should be fixed within a few weeks core Issues that should be addressed in Ray Core labels Jul 1, 2024
@scottjlee scottjlee added good-first-issue Great starter issue for someone just starting to contribute to Ray P1 Issue that should be fixed within a few weeks bug Something that is supposed to be working; but isn't and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. labels Jul 16, 2024
@xingyu-long
Copy link
Contributor

Hi @anyscalesam, I've raise the PR (#47072) to fix this issue, could you take a look? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't data Ray Data-related issues good-first-issue Great starter issue for someone just starting to contribute to Ray P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants