Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"ray/python/ray/tune/integration/wandb.py" should be removed #35781

Closed
ollie-iterators opened this issue May 25, 2023 · 1 comment · Fixed by #36860
Closed

"ray/python/ray/tune/integration/wandb.py" should be removed #35781

ollie-iterators opened this issue May 25, 2023 · 1 comment · Fixed by #36860
Assignees
@krfricke
Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical

Comments

@ollie-iterators
Copy link

ollie-iterators commented May 25, 2023 •
edited
Loading

What happened + What you expected to happen

ray/python/ray/tune/integration/wandb.py has a comment at the top of the file saying: # Deprecated: Remove whole file in 2.5

The current version of ray is 2.5, so this should be removed.

Versions / Dependencies

Main branch

Reproduction script

Look at: "ray/python/ray/tune/integration/wandb.py"

Issue Severity

Low: It annoys or frustrates me.
@ollie-iterators ollie-iterators added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 25, 2023
@ollie-iterators ollie-iterators changed the title class WandbTrainableMixin should be removed "ray/python/ray/tune/integration/wandb.py" should be removed Jun 9, 2023
@krfricke krfricke added P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jun 20, 2023
@krfricke krfricke self-assigned this Jun 20, 2023
@krfricke krfricke mentioned this issue Jun 27, 2023
Merged
8 tasks
@krfricke
Copy link
Contributor

Thanks, fixing in #36860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krfricke krfricke

Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tune] Remove deprecated mlflow+wandb aliases krfricke/ray
2 participants
@krfricke @ollie-iterators