Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Async actor check failures when non-async method is received after exit_actor #32376

Closed
rkooo567 opened this issue Feb 9, 2023 · 1 comment · Fixed by #32407
Closed
Assignees
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks Ray-2.4 size-medium

Comments

@rkooo567
Copy link
Contributor

rkooo567 commented Feb 9, 2023

What happened + What you expected to happen

import ray
ray.init()
import asyncio
@ray.remote
class A:
    async def f(self):
        await asyncio.sleep(1)
        ray.actor.exit_actor()

    def ping(self):
        pass

    # async def exit(self):
    #     ray.actor.exit_actor()

a = A.remote()
a.f.remote()
ray.get([a.ping.remote() for _ in range(10000)])

a.exit.remote()
a.other_method.remote()

This has a check failure

Versions / Dependencies

master

Reproduction script

see above

Issue Severity

None

@rkooo567 rkooo567 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) P0 Issues that should be fixed in short order core Issues that should be addressed in Ray Core Ray-2.4 and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Feb 9, 2023
@rkooo567 rkooo567 self-assigned this Feb 9, 2023
@rkooo567
Copy link
Contributor Author

Follow up: Talk to ML team

@rkooo567 rkooo567 added P1 Issue that should be fixed within a few weeks and removed P0 Issues that should be fixed in short order labels May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks Ray-2.4 size-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant