Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tune] PB2 is missing unit tests #29786

Closed
justinvyu opened this issue Oct 27, 2022 · 2 comments · Fixed by #31502
Closed

[Tune] PB2 is missing unit tests #29786

justinvyu opened this issue Oct 27, 2022 · 2 comments · Fixed by #31502
Assignees
@justinvyu
Labels
enhancement Request for new feature and/or capability P2 Important issue, but not time-critical testing topics about testing

Comments

@justinvyu
Copy link
Contributor

Description

PB2 is only tested via examples in tune/examples currently. We should add unit tests checking that PB2 scheduling behavior is correct.

See #29102 for an example of what should be tested.

Use case

No response
@justinvyu justinvyu added enhancement Request for new feature and/or capability P2 Important issue, but not time-critical testing topics about testing air labels Oct 27, 2022
@justinvyu justinvyu self-assigned this Oct 27, 2022
@adamelk
Copy link

adamelk commented Nov 1, 2022

Heads up, I'm pretty sure PB2 still doesn't work with nested hyperparam_bounds despite this pull request saying it fixed it: #29102

@justinvyu
Copy link
Contributor Author

Ah, that comment in the PR was a bit confusing, it was talking about fixing a general PBT logging issue for nested search spaces.

Tracking the nested PB2 hyperparam_bounds issue here: #30124

@justinvyu justinvyu mentioned this issue Jan 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinvyu justinvyu

Labels
enhancement Request for new feature and/or capability P2 Important issue, but not time-critical testing topics about testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tune] Add support for nested hyperparams in PB2 justinvyu/ray
2 participants
@adamelk @justinvyu