Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] trial_name_creator and trial_dirname_creator #29255

Closed
yinweisu opened this issue Oct 12, 2022 · 3 comments · Fixed by #30123
Closed

[Tune] trial_name_creator and trial_dirname_creator #29255

yinweisu opened this issue Oct 12, 2022 · 3 comments · Fixed by #30123
Labels
enhancement Request for new feature and/or capability tune Tune-related issues

Comments

@yinweisu
Copy link

Description

trial_name_creator and trial_dirname_creator are removed from ray tune in 2.0. It would be great if we can have them back.

Use case

Our use case wrap ray tune underneath and we will write artifacts along with ray tune artifacts in the trainable. We would like to write both ray tune and our own artifacts at the same location. With trial_name_creator and trial_dirname_creator, it's easier to do so

@yinweisu yinweisu added the enhancement Request for new feature and/or capability label Oct 12, 2022
@richardliaw richardliaw added the tune Tune-related issues label Oct 26, 2022
@justinvyu
Copy link
Contributor

Hi @yinweisu,

We're looking to add these utilities to the TuneConfig, but I wanted to ask if there were any additional functionality/improvements you would want from this API? Is it possible to share some more details about your use case?

In particular, is it useful to have the flexibility of constructing the name/dirname from the entire Trial object, or would it be clearer to only expose certain Trial attributes such as trainable_name, trial_id, and config? For example: trial_name_creator=lambda trainable_name, trial_id, config: f"{trainable_name}_{trial_id}"?

@yinweisu
Copy link
Author

yinweisu commented Nov 9, 2022

For my use case, the ability to control trial name and trial dirname is enough. Hoewver, as a developer, I would always want more api exposed. Guess it's your choice on what's easier to maintain

@PhilippWillms
Copy link

Thanks for enabling that. Especially in case of higher number of parameters to tune, the automatism creates too long filenames for Windows ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability tune Tune-related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants