Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get updates from Github releases #296

Closed
bacca87 opened this issue Aug 1, 2019 · 10 comments
Closed

Get updates from Github releases #296

bacca87 opened this issue Aug 1, 2019 · 10 comments

Comments

@bacca87
Copy link
Contributor

bacca87 commented Aug 1, 2019

Using the Github api you can download a json with the latest release:

https://api.github.com/repos/:owner/:repo/releases/latest

ex: https://api.github.com/repos/ravibpatel/AutoUpdater.NET/releases/latest

but the event AutoUpdaterOnParseUpdateInfoEvent is never fired.
can someone help me to understand why this is not working?

My code:

public void Main()
{
    AutoUpdater.ParseUpdateInfoEvent += AutoUpdaterOnParseUpdateInfoEvent;
    AutoUpdater.Start("https://api.github.com/repos/ravibpatel/AutoUpdater.NET/releases/latest");
}

private void AutoUpdaterOnParseUpdateInfoEvent(ParseUpdateInfoEventArgs args)
{
    dynamic json = JsonConvert.DeserializeObject(args.RemoteData);
    // do stuff
}

Thx in advice

@ravibpatel
Copy link
Owner

Can you try the new version from here. It should fix the issue.

@bacca87
Copy link
Contributor Author

bacca87 commented Aug 2, 2019

I'm already using this version and it doesn't work!

@bacca87
Copy link
Contributor Author

bacca87 commented Aug 2, 2019

I found the issue by myself and i made a pullrequest in order to fix that.

@ravibpatel
Copy link
Owner

Hi updated it but didn't updated the assembly version. Once you test it out I will do that.

@bacca87
Copy link
Contributor Author

bacca87 commented Aug 2, 2019

ok i checked your changes.
In my opinion could be better to add the possibility to set a custom useragent, if the custom user agent is not setted, you can use the default one.
This is useful in order to keep aligned the app user agent with the auto updater one.
Please let me know what you do think!

@ravibpatel
Copy link
Owner

I merged your changes. You can try it out from here.

@bacca87
Copy link
Contributor Author

bacca87 commented Aug 9, 2019

any plan for your next release? i need urgently this update and i need to understand if i can wait or is better to build this version by myself....

@ravibpatel
Copy link
Owner

Did you test out the latest changes I made? If it is working fine I can release the new version.

@bacca87
Copy link
Contributor Author

bacca87 commented Aug 9, 2019

Yes, i did and works as expected.
I've also fixed the italian translations #299

@ravibpatel
Copy link
Owner

I updated the NuGet package to v1.5.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants