Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting different username #225

Closed
donavanbecker opened this issue Aug 14, 2024 · 8 comments
Closed

Allow setting different username #225

donavanbecker opened this issue Aug 14, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@donavanbecker
Copy link
Contributor

would be nice if the username could be changed from admin to something else.

@dkerr64 dkerr64 added the enhancement New feature or request label Aug 17, 2024
@dkerr64
Copy link
Collaborator

dkerr64 commented Aug 17, 2024

Request noted. Yes username could be changed, just a small matter of programming it. Will consider for a future release.

@donavanbecker
Copy link
Contributor Author

With that would multi user support be useful?

@dkerr64
Copy link
Collaborator

dkerr64 commented Aug 17, 2024

With that would multi user support be useful?

I think that is a stretch. Much more complex to implement, and what's the point? I don't want to encourage use of the web interface... it should be for admin purposes only. Apple Home or other HomeKit apps is how most should interact with the door, not the web page.

I can think of a (quite niche case) where changing from "admin" to something else may be useful, but I'm not seeing it for multiuser.

David

@donavanbecker
Copy link
Contributor Author

Totally understand, I don't need it but figured I would propose it.

@dkerr64
Copy link
Collaborator

dkerr64 commented Aug 17, 2024

Will implement in next release whenever we do that... is in PR #227

@donavanbecker
Copy link
Contributor Author

Working awesome @dkerr64!!

Anyway to change the login pop up so that it supports autofill on mobile?

image

@dkerr64
Copy link
Collaborator

dkerr64 commented Aug 17, 2024

We're using basic browser-based digest authentication. The popup is generated by the browser so, AFAIK, I cannot influence how that popup appears or whether the mobile (or desktop) browser will offer to autofill the fields.

The alternative would be to implement our own login dialog... that requires we implement our own and not rely on browser-based digest authentication. This, in-fact, is best practice which is why you rarely see browser popups for userid/password anymore on web sites (it's considered insecure). But a lot of work I think and I'm not sure it is worth the effort especially given we cannot implement SSL (https).

@dkerr64
Copy link
Collaborator

dkerr64 commented Sep 23, 2024

included in v1.7.1

@dkerr64 dkerr64 closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants