Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issue in notebook ch06.ipynb #433

Closed
zia-hasan opened this issue Nov 14, 2024 · 1 comment · Fixed by #437
Closed

Small issue in notebook ch06.ipynb #433

zia-hasan opened this issue Nov 14, 2024 · 1 comment · Fixed by #437
Assignees
Labels
enhancement New feature or request

Comments

@zia-hasan
Copy link

zia-hasan commented Nov 14, 2024

Bug description

In cell [6], of ch06/01_main-chapter-code/ch06.ipynb, if the user runs the cell twice, "Label" column will become NaN. Perhaps a check would be nice or combine cell [5] and [6]

What operating system are you using?

Linux

Where do you run your code?

Local (laptop, desktop)

Environment




@zia-hasan zia-hasan added the bug Something isn't working label Nov 14, 2024
@rasbt rasbt added enhancement New feature or request and removed bug Something isn't working labels Nov 14, 2024
@rasbt
Copy link
Owner

rasbt commented Nov 14, 2024

That's a good point, thanks for suggesting. I added a modification to prevent the double execution via #437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants