You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some places in the codebase where the return type of __device__ functions is queried from host code. One such example is the use of std::result_of in cpp/include/raft/matrix/gather.cuh. The problem is that the return type of __device__ functions might not be correctly fetched from host code using such std headers. Some references to such concerns from the past are:
A fix therefore is to use cuda::std::result_of with cuda::proclaim_return_type to correctly obtain the return type of device functions (the corresponding headers are #include <cuda/std/type_traits> and #include <cuda/functional> respectively from libcudacxx), which indicates that this issue is a request to include libcudacxx as a raft dependency. This concern was raised in PR #1445.
The text was updated successfully, but these errors were encountered:
Just a note- we are planning to add this as a top-level dependency of RAFT soon anyways since we eventually need to migrate our mdspan/mdarray implementations to use those already in libcu++. The main gripe with the changes referenced above is that the dependency was added in the middle of a release in a somewhat unrelated PR. When we do add this dependency, we should do it in intentionally, make an announcement to community, and have it on our roadmap to alleviate surprises downstream.
There are some places in the codebase where the return type of
__device__
functions is queried from host code. One such example is the use ofstd::result_of
incpp/include/raft/matrix/gather.cuh
. The problem is that the return type of__device__
functions might not be correctly fetched from host code using suchstd
headers. Some references to such concerns from the past are:A fix therefore is to use
cuda::std::result_of
withcuda::proclaim_return_type
to correctly obtain the return type of device functions (the corresponding headers are#include <cuda/std/type_traits>
and#include <cuda/functional>
respectively fromlibcudacxx
), which indicates that this issue is a request to includelibcudacxx
as araft
dependency. This concern was raised in PR #1445.The text was updated successfully, but these errors were encountered: