Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]libcudf example doesn't build because of hardcoded old googletest version #11908

Closed
Char-Aznable opened this issue Oct 12, 2022 · 5 comments
Labels
1 - On Deck To be worked on next bug Something isn't working CMake CMake build issue

Comments

@Char-Aznable
Copy link

Describe the bug
A clear and concise description of what the bug is.

I am trying to build the libcudf example using cpp/examples/build.sh. It seems cudf hardcodes googletest version 1.10 into its config, which hits bugs google/googletest#3219 and google/googletest#4026 and therefore won't build.

Steps/Code to reproduce bug
Follow this guide http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports to craft a minimal bug report. This helps us reproduce the issue you're having and resolve the issue more quickly.

clone this repo and run cpp/examples/build.sh

Expected behavior
A clear and concise description of what you expected to happen.

The examples should be built.

Environment overview (please complete the following information)

  • Environment location: ubuntu 22.04, gcc 11.2 nvcc 11.7
  • Method of cuDF install: source
    • If method of install is [Docker], provide docker pull & docker run commands used

Environment details
Please run and paste the output of the cudf/print_env.sh script here, to gather any other relevant environment details

Additional context
Add any other context about the problem here.

@Char-Aznable Char-Aznable added Needs Triage Need team to review and classify bug Something isn't working labels Oct 12, 2022
@Char-Aznable
Copy link
Author

I'm not entirely sure whether this bug is due to libcudf's cmake config or rather it's due to rapids-cmake's https://github.com/rapidsai/rapids-cmake/blob/branch-22.12/rapids-cmake/cpm/versions.json file that hardcodes googletest version 1.10

@davidwendt
Copy link
Contributor

I'm not able to reproduce this. Can you paste what error you are seeing? Can you try with gcc 9.5 ?

@Char-Aznable
Copy link
Author

The error was exactly those in the OP of google/googletest#3219. I don't have gcc 9.5 but gcc 9.4 can compile without error.

@davidwendt
Copy link
Contributor

@robertmaynard

@GregoryKimball GregoryKimball added 1 - On Deck To be worked on next CMake CMake build issue and removed Needs Triage Need team to review and classify labels Oct 21, 2022
@vyasr
Copy link
Contributor

vyasr commented May 17, 2024

RAPIDS is now on gtest 1.13 so this shouldn't be an issue any longer.

@vyasr vyasr closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - On Deck To be worked on next bug Something isn't working CMake CMake build issue
Projects
None yet
Development

No branches or pull requests

4 participants