Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination - last page #28

Closed
asharma-r7 opened this issue Aug 14, 2015 · 3 comments
Closed

Pagination - last page #28

asharma-r7 opened this issue Aug 14, 2015 · 3 comments

Comments

@asharma-r7
Copy link
Contributor

The issue occurs when there is an equal number of rows spanning across all pages and clicking on the 'last page' indicator.

For example, a collection that contains 30 models is used with a table with the 'perPage' property set to 10. There will be 3 pages available to the user (with an exact amount of rows per page). Clicking on the 'last page' indicator on the Carpenter pagination area will display 'No items were found.', instead of the expected 10 items.

I put together a jsfiddle to illustrate the problem - http://jsfiddle.net/amito93/xb0grotj/

@mbuck-r7
Copy link
Contributor

Thanks for the report! Awesome that you included an example. I'm not quite sure what's happening off the top of my head, so I'll have to dig in as soon as I have some extra bandwidth - which will be next week, at the earliest. We're using an old version of backbone paginator, so my initial suspicion would be that the problem lies there. We're planning on upgrading it as soon as we begin work on the new version of this component.

@asharma-r7
Copy link
Contributor Author

Thanks!

@claughlin-r7
Copy link
Contributor

fixed with #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants