Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECharts for Mux/WebSockets changes #69

Closed
randyzwitch opened this issue Mar 22, 2019 · 5 comments
Closed

Update ECharts for Mux/WebSockets changes #69

randyzwitch opened this issue Mar 22, 2019 · 5 comments

Comments

@randyzwitch
Copy link
Owner

As of today, need JuliaWeb/Mux.jl#86 and JuliaWeb/WebSockets.jl#145 for ECharts to pop up a Blink window

@randyzwitch
Copy link
Owner Author

v0.2.0 that was just tagged pins HTTP at 0.7.1. When above PRs are merged resolved, figure out what to do

@hustf
Copy link

hustf commented Mar 23, 2019

Hi, thanks for a great package and sorry for the downstream trouble from HTTP->WebSockets->Mux. Just a comment while waiting for tests, hope that's okay.

The package system is really flexible and smart, but I think we can generally reduce the potential error space by removing crosslinks, i.e. capping our direct dependencies (and say nothing about indirect dependencies).

So e.g., in REQUIRE:
Mux 0.6.0 0.6.99
would in theory protect you from upstream interface changes. If we follow the semantic versioning.

And if you require, say, HTTP 0.9 directly somewhere else, Julia will download both versions for us and work great in their context.

@piever
Copy link

piever commented Mar 23, 2019

I've just released Mux 0.7 (to be merged in METADATA JuliaLang/METADATA.jl#22382), please let me know if this is enough to fix ECharts (in which case maybe the easier is to drop the HTTP upperbound: if anything it is up to Mux to add a HTTP upperbounds for safety).

@randyzwitch
Copy link
Owner Author

Thanks for the solutions @hustf and @piever, I hope I didn't give off a vibe like I was angry. These things happen, thanks for all the hard work making HTTP and the related packages better :)

@randyzwitch
Copy link
Owner Author

I feel think this is probably fixed by #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants