Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate for Fleet 0.10 / Rancher 2.9 #2151

Closed
3 of 5 tasks
weyfonk opened this issue Feb 14, 2024 · 3 comments
Closed
3 of 5 tasks

Release Candidate for Fleet 0.10 / Rancher 2.9 #2151

weyfonk opened this issue Feb 14, 2024 · 3 comments

Comments

@weyfonk
Copy link
Contributor

weyfonk commented Feb 14, 2024

With recent refactorings (migration to controller-runtime, #2008, etc), Fleet 0.10 will require special attention.

This includes the following checklist, copied over from #2008:

  • Remove packages/fleet/gitjob from rancher/charts' target branch (eg. by editing the PR generated by release-against-charts)
  • Check if newly generated index.yaml entry in rancher/charts still includes gitjob as a chart; it should not.
  • Check that packages/fleet/fleet/generated-changes no longer contains references to gitjob
  • Check that the auto-generated release PR against rancher/charts does not add any docker.io/rancher/gitjob tag entry to regsync.yaml, but generates an entry for docker.io/rancher/fleet-gitjob instead.
  • Test installing that Fleet release in Rancher.
@weyfonk weyfonk added this to Fleet Feb 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Fleet Feb 14, 2024
@weyfonk weyfonk moved this from 🆕 New to 📋 Backlog in Fleet Feb 14, 2024
@weyfonk weyfonk added this to the v2.9.0 milestone Feb 14, 2024
@manno manno changed the title Release Fleet 0.10 Release Candidate for Fleet 0.10 Feb 14, 2024
@manno manno changed the title Release Candidate for Fleet 0.10 Release Candidate for Fleet 0.10 / Rancher 2.9 Feb 14, 2024
@thardeck thardeck self-assigned this Feb 29, 2024
@thardeck thardeck moved this from 📋 Backlog to 🏗 In progress in Fleet Feb 29, 2024
@thardeck thardeck moved this from 🏗 In progress to Blocked in Fleet Mar 5, 2024
@thardeck thardeck moved this from Blocked to 🏗 In progress in Fleet Mar 5, 2024
@thardeck thardeck moved this from 🏗 In progress to ✅ Done in Fleet Mar 7, 2024
@thardeck thardeck moved this from ✅ Done to 🏗 In progress in Fleet Mar 7, 2024
@thardeck
Copy link
Contributor

thardeck commented Mar 7, 2024

It seems regsync is updated by a label on a pr via a Github action: https://github.com/rancher/charts/blob/dev-v2.9/.github/workflows/regsync-config.yaml
When we submitted Fleet 0.10.0-rc.4 we did not set a label so I have pinged the Maps team on Slack.

@thardeck
Copy link
Contributor

Regarding regsync I got the following information:
We do not use that action in the dev branches. Only in the release branches.

So I guess it should be fine from our side for now.

@thardeck thardeck moved this from 🏗 In progress to 👀 In review in Fleet Mar 21, 2024
@thardeck thardeck moved this from 👀 In review to Blocked in Fleet Mar 21, 2024
@manno
Copy link
Member

manno commented May 15, 2024

@weyfonk can we close this? :)

@weyfonk weyfonk closed this as completed May 16, 2024
@github-project-automation github-project-automation bot moved this from Blocked to ✅ Done in Fleet May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants