Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to wrangler/v2 #1777

Closed
manno opened this issue Sep 12, 2023 · 4 comments
Closed

Bump to wrangler/v2 #1777

manno opened this issue Sep 12, 2023 · 4 comments
Assignees
@aruiz14
Labels
kind/chore
Milestone
v2.8.3

Comments

@manno
Copy link
Member

manno commented Sep 12, 2023

Mocks break, see rancher/rancher#41817
@manno manno added this to Fleet Sep 11, 2023
@manno manno converted this from a draft issue Sep 12, 2023
@manno manno added this to the 2024-Q1-2.8x milestone Sep 12, 2023
@aruiz14
Copy link
Contributor

aruiz14 commented Sep 12, 2023

We need to bump it in gitjob too, since GitJobController embeds wrangler's generic.ControllerMeta interface.

@aruiz14 aruiz14 self-assigned this Sep 13, 2023
This was referenced Sep 13, 2023
Merged
Merged
@aruiz14
Copy link
Contributor

aruiz14 commented Sep 18, 2023

related: rancher/gitjob#315

@manno manno moved this from 📋 Backlog to 🏗 In progress in Fleet Sep 20, 2023
@manno manno moved this from 🏗 In progress to Needs QA review in Fleet Sep 20, 2023
@manno manno moved this from Needs QA review to Blocked in Fleet Sep 20, 2023
@manno manno moved this from Blocked to 📋 Backlog in Fleet Oct 19, 2023
@manno manno mentioned this issue Oct 19, 2023
Closed
@aruiz14
Copy link
Contributor

aruiz14 commented Oct 20, 2023

@manno I'm afraid that we are still blocked here. I tried upgrading the import paths to wrangler/v2 but there is still no version of lasso using v2. It's not possible to keep both versions of wrangler because steve's /pkg/aggregation expects a v1 handler.

@aruiz14 aruiz14 moved this from 📋 Backlog to 🏗 In progress in Fleet Oct 20, 2023
@aruiz14
Copy link
Contributor

aruiz14 commented Oct 20, 2023

Not blocked anymore, since we tackled: rancher/gitjob#339

@aruiz14 aruiz14 mentioned this issue Oct 23, 2023
Merged
@aruiz14 aruiz14 moved this from 🏗 In progress to ✅ Done in Fleet Oct 23, 2023
@aruiz14 aruiz14 closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aruiz14 aruiz14

Labels
kind/chore
Projects
Fleet
Archived in project
Milestone
v2.8.3
Development

No branches or pull requests
2 participants
@manno @aruiz14