Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autobumper should not add version if there is no version key #842

Closed
Itxaka opened this issue Nov 4, 2021 · 1 comment
Closed

Autobumper should not add version if there is no version key #842

Itxaka opened this issue Nov 4, 2021 · 1 comment
Labels
area/automation kind/bug Something isn't working

Comments

@Itxaka
Copy link
Contributor

Itxaka commented Nov 4, 2021

cos-toolkit version:
master

CPU architecture, OS, and Version:
N/A

Describe the bug
Currently we use anchors on the cos collection.yaml file to avoid repeating some of the stuff, including version numbers for all the different cos-whatever artifacts.
This keeps the versions in sync, especially between the cos system and cos recovery, as they should always match,

Autobumper is adding version numbers to those entries and may desync them, so you end up with a recovery with a version and a system with another.

The contents are the same, so its not a big problem but it could lead to confusion, after a cos-reset of one of your nodes in a cluster it suddenly reports a different version number for example.

To Reproduce
have a recovery with a different version number than your cos system, run cos-reset, check version number

Expected behavior
Recovery and system to have the same version.

Logs
Tests cached this https://github.com/rancher-sandbox/cOS-toolkit/runs/4097481553?check_suite_focus=true

Additional context

@Itxaka Itxaka added the kind/bug Something isn't working label Nov 4, 2021
@mudler mudler removed their assignment Nov 4, 2021
@mudler mudler moved this to ❆ Icebox in Elemental Jun 1, 2022
@mudler mudler added this to Elemental Jun 1, 2022
@kkaempf kkaempf moved this from ❆ Icebox to 💡 Incoming in Elemental Aug 9, 2022
@Itxaka
Copy link
Contributor Author

Itxaka commented Dec 15, 2022

This can be closed. If its not implemented already its not gonna be and its only a bit annoying not a real bug

@Itxaka Itxaka closed this as completed Dec 15, 2022
Repository owner moved this from 💡 Incoming to ✅ Done in Elemental Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation kind/bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants