Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set kernel-parameters for build-iso #1764

Closed
frelon opened this issue May 12, 2023 · 1 comment · Fixed by #2072
Closed

Set kernel-parameters for build-iso #1764

frelon opened this issue May 12, 2023 · 1 comment · Fixed by #2072
Assignees
@frelon
Labels
area/iso kind/enhancement New feature or request
Milestone
Micro6

Comments

@frelon
Copy link
Contributor

frelon commented May 12, 2023

The build-iso command sets hardcoded kernel parameters here https://github.com/rancher/elemental-cli/blob/133e72f7b26d6d2b0663545861b7202d000d0930/pkg/live/common.go#LL66C53-L66C53

It should be possible to influence those parameters by cmdline flags or config-file.

This issue is probably not a duplicate of #1773
@frelon frelon mentioned this issue May 12, 2023
Open
@frelon frelon added the kind/enhancement New feature or request label May 12, 2023
@frelon frelon transferred this issue from rancher/elemental-cli May 23, 2023
@frelon frelon added this to Elemental May 31, 2023
@frelon frelon moved this to 🏃🏼‍♂️ In Progress in Elemental May 31, 2023
@frelon frelon moved this from 🏃🏼‍♂️ In Progress to 🗳️ To Do in Elemental May 31, 2023
@frelon
Copy link
Contributor Author

frelon commented May 31, 2023

After #1766 is merged I'm starting to think we can move these embedded config files into a live-grub-config feature.

@kkaempf kkaempf removed this from Elemental Aug 22, 2023
@frelon frelon mentioned this issue May 7, 2024
Closed
@kkaempf kkaempf added this to Elemental May 7, 2024
@kkaempf kkaempf added this to the Micro6 milestone May 7, 2024
@kkaempf kkaempf moved this to 🗳️ To Do in Elemental May 7, 2024
@frelon frelon self-assigned this May 8, 2024
@frelon frelon moved this from 🗳️ To Do to 🏃🏼‍♂️ In Progress in Elemental May 8, 2024
@frelon frelon linked a pull request May 8, 2024 that will close this issue
Add extra-cmdline flag to build-iso command #2072
Merged
@frelon frelon moved this from 🏃🏼‍♂️ In Progress to 👀 Needs review in Elemental May 10, 2024
@github-project-automation github-project-automation bot moved this from 👀 Needs review to ✅ Done in Elemental May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frelon frelon

Labels
area/iso kind/enhancement New feature or request
Projects
Elemental
Archived in project
Milestone
Micro6
Development

Successfully merging a pull request may close this issue.

Add extra-cmdline flag to build-iso command frelon/elemental-toolkit
2 participants
@kkaempf @frelon