Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing market field on the album API call #423

Closed
rileyallyn opened this issue Jun 2, 2023 · 1 comment · Fixed by #432
Closed

Missing market field on the album API call #423

rileyallyn opened this issue Jun 2, 2023 · 1 comment · Fixed by #432
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@rileyallyn
Copy link

Describe the bug
The album function

async fn album(&self, album_id: AlbumId<'_>) -> ClientResult<FullAlbum> {
does not have a param for the market field which is in the API documentation.

To Reproduce
Steps to reproduce the behavior:
N/A

Expected behavior
Having a market field

Log/Output data
N/A

Additional context
https://developer.spotify.com/documentation/web-api/reference/get-an-album and https://developer.spotify.com/documentation/web-api/concepts/track-relinking

@rileyallyn rileyallyn added bug Something isn't working help wanted Extra attention is needed labels Jun 2, 2023
@ramsayleung
Copy link
Owner

I think Spotify just updated their API by adding a new field named market, RSpotify should update the album endpoint accordingly.

So, feel free to create a PR to fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants