From 9ebc58cbb759a7df3b31388d02fb66871925013a Mon Sep 17 00:00:00 2001
From: Matthew Richards <matthew.richards@stfc.ac.uk>
Date: Fri, 15 Jan 2021 14:32:40 +0000
Subject: [PATCH]  #163: Remove Python 3.4 from CI build

---
 .github/workflows/ci-build.yml | 2 +-
 README.md                      | 8 +++++++-
 noxfile.py                     | 2 +-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml
index 4564e667..6e79a15c 100644
--- a/.github/workflows/ci-build.yml
+++ b/.github/workflows/ci-build.yml
@@ -5,7 +5,7 @@ jobs:
     runs-on: ubuntu-16.04
     strategy:
       matrix:
-        python-version: ['3.4.10', '3.5', '3.6', '3.7', '3.8', '3.9']
+        python-version: ['3.5', '3.6', '3.7', '3.8', '3.9']
     name: Python ${{ matrix.python-version }} Build
     steps:
     - name: Add apt repo
diff --git a/README.md b/README.md
index 5c41d547..fbc6c3dc 100644
--- a/README.md
+++ b/README.md
@@ -90,17 +90,23 @@ development environment for this repo. This stage might take some time as each P
 version needs to be downloaded and built individually:
 
 ```bash
+pyenv install 3.4.10
+pyenv install 3.5.10
 pyenv install 3.6.8
 pyenv install 3.7.7
 pyenv install 3.8.2
+pyenv install 3.9.0
 ```
 
 To verify the installation commands worked:
 
 ```bash
+python3.4 --version
+python3.5 --version
 python3.6 --version
 python3.7 --version
 python3.8 --version
+python3.9 --version
 ```
 
 These Python versions need to be made available to local version of the repository. They
@@ -109,7 +115,7 @@ following command will create a `.python-version` file inside the repo (this fil
 currently listed in `.gitignore`):
 
 ```bash
-pyenv local 3.6.8 3.7.7 3.8.2
+pyenv local 3.4.10 3.5.10 3.6.8 3.7.7 3.8.2 3.9.0
 ```
 
 
diff --git a/noxfile.py b/noxfile.py
index f3385a05..d4842eaa 100644
--- a/noxfile.py
+++ b/noxfile.py
@@ -82,7 +82,7 @@ def safety(session):
             session.log("Error: The temporary requirements file could not be closed")
 
 
-@nox.session(python=["3.4", "3.5", "3.6", "3.7", "3.8", "3.9"], reuse_venv=True)
+@nox.session(python=["3.5", "3.6", "3.7", "3.8", "3.9"], reuse_venv=True)
 def tests(session):
     args = session.posargs
     session.run("poetry", "install", external=True)