From 268dac3b2e90b5caa0fce66fb470eac96b63d565 Mon Sep 17 00:00:00 2001 From: Matthew Richards Date: Mon, 22 Feb 2021 16:46:26 +0000 Subject: [PATCH] #119: Fix tests for change to no results behaviour - A couple of commits ago, the ICAT backend was changed so that 404s no longer occur when no results are found. This is because no results being found is correct behaviour, so should give a 200 --- test/icat/endpoints/test_get_with_filters_icat.py | 2 +- test/icat/endpoints/test_table_endpoints_icat.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/icat/endpoints/test_get_with_filters_icat.py b/test/icat/endpoints/test_get_with_filters_icat.py index b05e8160..daf31f88 100644 --- a/test/icat/endpoints/test_get_with_filters_icat.py +++ b/test/icat/endpoints/test_get_with_filters_icat.py @@ -28,7 +28,7 @@ def test_valid_no_results_get_with_filters( headers=valid_icat_credentials_header, ) - assert test_response.status_code == 404 + assert test_response.json == [] @pytest.mark.usefixtures("multiple_investigation_test_data") def test_valid_get_with_filters_distinct( diff --git a/test/icat/endpoints/test_table_endpoints_icat.py b/test/icat/endpoints/test_table_endpoints_icat.py index a62b3c63..38960e47 100644 --- a/test/icat/endpoints/test_table_endpoints_icat.py +++ b/test/icat/endpoints/test_table_endpoints_icat.py @@ -30,7 +30,7 @@ def test_invalid_get_facility_cycles_with_filters( headers=valid_icat_credentials_header, ) - assert test_response.status_code == 404 + assert test_response.json == [] def test_valid_get_facility_cycles_count_with_filters( self, @@ -84,7 +84,7 @@ def test_invalid_get_investigations_with_filters( headers=valid_icat_credentials_header, ) - assert test_response.status_code == 404 + assert test_response.json == [] def test_valid_get_investigations_count_with_filters( self,