Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes Request not show when use isMethod condition #114

Closed
paul-lestyo opened this issue Jan 18, 2023 · 3 comments
Closed

Attributes Request not show when use isMethod condition #114

paul-lestyo opened this issue Jan 18, 2023 · 3 comments

Comments

@paul-lestyo
Copy link

hi, I'm new here
when I try to use isMethod condition in Request Class, the documentation does't show like below.

my request
image

documentation
image

is there any solution regarding this? thx

@kevincobain2000
Copy link
Member

The solution to fix this is to not use the same request class for 2 different API routes/methods.
One of the motivations to develop this LRD was to actually identify bad design patterns that can lead to spaghetti.

My suggestion is that you could choose to use inheritance and that would make your code much cleaner and more scalable.

@kevincobain2000
Copy link
Member

kevincobain2000 commented Jan 18, 2023

Having said so, after our UI renewal #103, I ll work on addressing support to somewhat similar problem, where LRD be able to generate missing documentation by calling the actual API on top of what we already have - reflection class.

@paul-lestyo
Copy link
Author

@kevincobain2000 OK thanks for the advice. I will consider separating the classes for the different methods and I can't wait for the new update from this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants