-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local lyrics source #29
Comments
This can certainly be implemented by applying some kind of fuzzy search in a directory with |
After looking a bit more into this myself: |
Well, I implemented it... kind of. You can check the local branch. The current implementation goes through the specified folder, finds the .lrc files and creates an index of these files. Each file is presented as a list of words in its name. Then, for each query, for each file in the index, it calculates a "score" - how many words in the query are equal to the words in the file name. The file with the maximum score is used. The complexity is It works fine on all the tracks I've tested it on. But testing is required to find all the edge cases. And it would be great to find a more effective algorithm. |
Liking the .lrc support, however why not just parse from the lyrics tag in the file? Can use a script like https://github.com/TheRedSpy15/lrcput to embed all your .lrc files, and then there's no guessing! |
As mentioned in #22 (comment), downloading lyrics is a bit out of scope for this application, but since it was mentioned there are other ways to do this, would it be reasonable to allow for this application to show downloaded lyrics, forgoing an API? I think it would provide a lot of peace of mind knowing that the lyrics will always be there for you. From the name I'm guessing this project started out only for Spotify, but for people who use MPD or other local players I think this is a not too uncommon concern.
The text was updated successfully, but these errors were encountered: